Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc-v2/tx: Rename transaction to transactionWatch #3040

Merged
merged 3 commits into from
Jan 25, 2024
Merged

rpc-v2/tx: Rename transaction to transactionWatch #3040

merged 3 commits into from
Jan 25, 2024

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Jan 24, 2024 •
edited
Loading

This PR backports the changes from paritytech/json-rpc-interface-spec#107.

The transaction class becomes transactionWatch, and the other functionality remains the same.

// cc @paritytech/subxt-team

@lexnv
rpc-v2/tx: Rename transaction to transactionWatch
f02f063 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv added I5-enhancement An additional feature request. T3-RPC_API This PR/Issue is related to RPC APIs. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Jan 24, 2024
@lexnv lexnv self-assigned this Jan 24, 2024
@lexnv
prdoc: Add prdoc
d5ee5b5 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
prodoc: Names must have no : entries
a0420a7 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
jsdw
jsdw approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick turnaround :)

niklasad1
niklasad1 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Any plans to add these new methods transaction_unstable_broadcast and transaction_unstable_stop as well or file an issue for it?

@lexnv
Copy link
Contributor Author

lexnv commented Jan 24, 2024

Yep yep, I'm currently looking into adding the broadcast methods, I've already created an issue for it 🙏

I felt this PR is quite small and went ahead without an issue :D

The overarching V2 implementation can be tracked at:

@lexnv lexnv added this pull request to the merge queue Jan 25, 2024
Merged via the queue into master with commit 5c79ed3 Jan 25, 2024
125 of 126 checks passed
@lexnv lexnv deleted the lexnv/rename-tx branch January 25, 2024 17:52
tadeohepperle
tadeohepperle reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@tadeohepperle tadeohepperle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@lexnv
rpc-v2/tx: Rename transaction to transactionWatch (paritytech#3040)
f4cad1c 
This PR backports the changes from
paritytech/json-rpc-interface-spec#107.

The `transaction` class becomes `transactionWatch`, and the other
functionality remains the same.

// cc @paritytech/subxt-team

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@Aideepakchaudhary Aideepakchaudhary mentioned this pull request Oct 14, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeohepperle tadeohepperle tadeohepperle left review comments

@niklasad1 niklasad1 niklasad1 approved these changes

@jsdw jsdw jsdw approved these changes

Assignees

@lexnv lexnv

Labels
D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I5-enhancement An additional feature request. T3-RPC_API This PR/Issue is related to RPC APIs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lexnv @jsdw @niklasad1 @tadeohepperle